Repository navigation
feat(transformation): Adding data domain external id in the transformation apis - #2872
ankuagarwal wants to merge 5 commits into
Conversation
ankuagarwal
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for filtering and managing transformations by data_domain_external_id across the sync and async APIs, data classes, and filters. Feedback on the changes highlights a few issues: incorrect imports and fixture names (pytest_httpx2 and httpx2_mock) in the unit tests, redundant manual tests for load/dump/update methods that violate the style guide, and a recommendation to use keyword arguments instead of positional arguments in TransformationWrite.copy() for improved maintainability.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2872 +/- ##
==========================================
- Coverage 93.58% 93.58% -0.01%
==========================================
Files 533 534 +1
Lines 56210 56247 +37
==========================================
+ Hits 52602 52636 +34
- Misses 3608 3611 +3
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for filtering and managing transformations by data_domain_external_id (and data_domain_external_ids for filtering) across the sync and async clients, data classes, and updates. The review feedback highlights critical typos in the unit tests, specifically importing pytest_httpx2 instead of pytest_httpx and using httpx2_mock instead of httpx_mock, which will break the test suite. Additionally, it is recommended to refactor TransformationWrite.copy() to use keyword arguments instead of positional arguments to improve maintainability and align with existing patterns.
|
Transformation APIs already has this implemented and deployed, right? |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
haakonvt
added
risk-review-ongoing
Description
data_domain_external_idas part of transformation create/update request & response objectdata_domain_external_idsas part of list/filter calls for transformations.Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.